Skip to content

Replace loose equality with strict equality in SignInControl#1392

Merged
mattwoberts merged 2 commits intologin_codesfrom
copilot/sub-pr-1389
Nov 15, 2025
Merged

Replace loose equality with strict equality in SignInControl#1392
mattwoberts merged 2 commits intologin_codesfrom
copilot/sub-pr-1389

Conversation

Copy link
Contributor

Copilot AI commented Nov 15, 2025

Addresses code review feedback from #1389 to use strict equality operators for type-safe comparisons.

Changes

  • Replaced 7 instances of == with === in SignInControl.tsx:
    • Enum comparisons in renderSigninEmailButton() (3 instances)
    • Conditional rendering logic for form fields (3 instances)
    • Email input disabled prop (1 instance)

All changes involve comparisons against the EmailSigninStep enum:

// Before
if (emailSignInStep == EmailSigninStep.EnterEmail) { ... }

// After  
if (emailSignInStep === EmailSigninStep.EnterEmail) { ... }

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: mattwoberts <109196+mattwoberts@users.noreply.github.com>
Copilot AI changed the title [WIP] Address feedback on login codes draft Replace loose equality with strict equality in SignInControl Nov 15, 2025
Copilot AI requested a review from mattwoberts November 15, 2025 16:11
@mattwoberts mattwoberts marked this pull request as ready for review November 15, 2025 16:13
@mattwoberts mattwoberts merged commit ff24be7 into login_codes Nov 15, 2025
@mattwoberts mattwoberts deleted the copilot/sub-pr-1389 branch November 15, 2025 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants